gh-143750: Compile OpenSSL with TSan for TSan CI #143752
Draft
+38
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also fix "Install dependencies" step so that we use the installed Clang. We can use clang-20 on both ASan and TSan now.
webknjaz
reviewed
Jan 15, 2026
Comment on lines
+26
to
+31
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-24.04] | ||
| openssl_ver: [3.5.4] | ||
| runs-on: ${{ matrix.os }} |
Member
There was a problem hiding this comment.
Plz move these to inputs: and host the matrix on the calling side (in build.yml). This is the separation I was going for when I first introduced the reusable-*.yml module pattern — no matrices in modules.
Comment on lines
23
to
25
| && ' (free-threading)' | ||
| || '' | ||
| }} |
Member
There was a problem hiding this comment.
This will also need to interpolate new matrix factors since the job names will be confusing if there's ever more than one job.
Comment on lines
+58
to
59
| run: | | ||
| if [ "${SANITIZER}" = "TSan" ]; then |
Member
There was a problem hiding this comment.
We can move this conditional to the GHA step so that skipping is more prominent.
Suggested change
| run: | | |
| if [ "${SANITIZER}" = "TSan" ]; then | |
| if: inputs.sanitizer == 'TSan' | |
| run: | |
Also drop fi and the second conditional block below too.
| || '--with-undefined-behavior-sanitizer' | ||
| }} | ||
| --with-pydebug | ||
| ${{ inputs.sanitizer == 'TSan' && ' --with-openssl="$OPENSSL_DIR" --with-openssl-rpath=auto' || '' }} |
Member
There was a problem hiding this comment.
(nit) no need for the whitespace since >- in YAML already adds whitespaces when it joins the lines on parsing.
Suggested change
| ${{ inputs.sanitizer == 'TSan' && ' --with-openssl="$OPENSSL_DIR" --with-openssl-rpath=auto' || '' }} | |
| ${{ inputs.sanitizer == 'TSan' && '--with-openssl="$OPENSSL_DIR" --with-openssl-rpath=auto' || '' }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix "Install dependencies" step so that we use the installed Clang. We can use clang-20 on both TSan and UBSan now.